Skip to content

Bugfix/dcc redesign bugfixes #3472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 9, 2025
Merged

Bugfix/dcc redesign bugfixes #3472

merged 5 commits into from
Oct 9, 2025

Conversation

@KoolADE85
Copy link
Contributor

@KoolADE85 KoolADE85 commented Oct 8, 2025 •
edited
Loading

This PR addresses feedback/bugs reported in the Slider and Dropdown redesigns:

  • adds reverse prop to Slider and RangeSlider
  • fixes bug where user cannot type into text input of slider (i.e. do not constrain/validate text inputs until after blurring off the input)
  • add tests for the above
  • fix bug with dynamic input sizes when using a slider within DDK
  • add focus state to dropdown

@gvwilson gvwilson added P1 needed for current cycle fix fixes something broken labels Oct 9, 2025
@KoolADE85 KoolADE85 merged commit 504c65d into v4 Oct 9, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@T4rk1n T4rk1n Awaiting requested review from T4rk1n T4rk1n is a code owner

@ndrezn ndrezn Awaiting requested review from ndrezn ndrezn is a code owner

@emilykl emilykl Awaiting requested review from emilykl emilykl is a code owner

1 more reviewer

@gvwilson gvwilson gvwilson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@KoolADE85 KoolADE85

Labels

fix fixes something broken P1 needed for current cycle

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@KoolADE85 @gvwilson