Skip to content

Handle actual zero values as other numbers rather than as unsupplied #1012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Handle actual zero values as other numbers rather than as unsupplied #1012

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d60b09a
Change Lib.coerce2 so it doesn't return false for falsey things (0, "…
monfera Oct 5, 2016
6396301
Perform logic such that a specified zero value doesn't mean false in …
monfera Oct 5, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/lib/coerce.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,7 @@ exports.coerce2 = function(containerIn, containerOut, attributes, attribute, dfl
var propIn = nestedProperty(containerIn, attribute),
propOut = exports.coerce(containerIn, containerOut, attributes, attribute, dflt);

return propIn.get() ? propOut : false;
return propIn.get() !== undefined ? propOut : false;
};

/*
Expand Down
2 changes: 1 addition & 1 deletion src/traces/contour/defaults.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ module.exports = function supplyDefaults(traceIn, traceOut, defaultColor, layout

var contourStart = Lib.coerce2(traceIn, traceOut, attributes, 'contours.start'),
contourEnd = Lib.coerce2(traceIn, traceOut, attributes, 'contours.end'),
autocontour = coerce('autocontour', !(contourStart && contourEnd));
autocontour = coerce('autocontour', contourStart === false || contourEnd === false);
Copy link
Contributor

@etpinard etpinard Oct 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. @monfera would you mind adding a test case for this in the contour_test.js suite?


if(autocontour) coerce('ncontours');
else coerce('contours.size');
Expand Down