Skip to content

add eslint eol-last rule #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 8, 2016
Merged

add eslint eol-last rule #321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
581b6d6
list two already enforced rules:
etpinard Mar 8, 2016
b1c2b15
enforce eol-last rule (all file must end with \n)
etpinard Mar 8, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .eslintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
"rules": {
"no-trailing-spaces": [2],
"no-multiple-empty-lines": [2, {"max": 2, "maxEOF": 1}],
"eol-last": [2],
"linebreak-style": [2, "unix"],
"indent": [2, 4, {"SwitchCase": 1}],
"max-len": [0, 80],
Expand All @@ -32,9 +33,12 @@
"space-before-function-paren": [2, "never"],
"space-before-blocks": [2],
"no-multi-spaces": [2],
"no-whitespace-before-property": [2],
Copy link
Contributor Author

@etpinard etpinard Mar 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one may also be useful.

"no-unexpected-multiline": [2],
"space-infix-ops": [0, {"int32Hint": false}],
"quotes": [2, "single"],
"dot-notation": [2, {"allowKeywords": false}],
"operator-linebreak": [2, "after"],
Copy link
Contributor Author

@etpinard etpinard Mar 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This rule is already seen across the repo. It is now enforced.

"eqeqeq": [2],
"new-cap": [0],
"no-redeclare": [2, {"builtinGlobals": true}],
Expand All @@ -44,7 +48,6 @@
"no-use-before-define": [2, "nofunc"],
"no-loop-func": [2],
"no-console": [0],
"no-unexpected-multiline": [2],
"no-unused-labels": [2]
},
}
2 changes: 1 addition & 1 deletion test/jasmine/tests/hover_label_test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,4 +430,4 @@ describe('hover info on stacked subplots', function() {
expect(textNodes[2][1].innerHTML).toEqual('3');
});
});
});
});