Contour colormap cleanup #367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- contour colorbar and style now call same color map function creator - contourgl will used the same makeColorMap
| start = contours.start, | ||
| end = contours.end, | ||
| cs = contours.size || 1, | ||
| nc = Math.floor((end + cs / 10 - start) / cs) + 1, |
Contributor
There was a problem hiding this comment.
Can we use more verbose names? cs I can understand as contour size but I have no idea what nc is.
Contributor
Author
There was a problem hiding this comment.
nc : number of contours.
Contributor
|
💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mdtusz
Some clean up in
traces/contourto make gl2d contour integration easier. In brief, this PRcontours.coloringset to'heatmap'and'lines')contourgl) use the same logic