Corrected typo in histogram hover

[emmanuelle]

I think there was a typo here, but I may be missing something.

[archmoj]

Good catch.
@emmanuelle so because of this, hovertemplate was not working on histogram?

[emmanuelle]

I'm very confused because hovertemplate does work as I just checked (screenshot from Python sorry but you'll get the idea)

[emmanuelle]

of maybe the if was always True?

[archmoj]

Most likely this should be labled as bug.
Anyway it would be good to know which issue we are closing.
@antoinerg any idea?

[antoinerg]

Thank you @emmanuelle for spotting this ridiculous line of code of mine. Actually, it is completely unnecessary and it should be removed. All tests pass without it: d88d243

Please remove it and I'll approve the change 😸

[archmoj]

Please wait Plotly.PlotSchema.get().traces.histogram.attributes.hovertemplate gives me

{valType: "string", dflt: "", editType: "none", arrayOk: true}

So in the case of blank string (i.e. the plotly.js default) hovertemplate is disabled.

[antoinerg]

@archmoj I'm not sure I understand what you're getting at? Are you saying that d88d243 is not OK?

[archmoj]

That commit is good; and we likely need to keep the if statement.
But wondering what should be the result in the case of a blank item in the array vs the blank default? Here is a demo.

[archmoj]

TODO:

• remove if statement as proposed in Corrected typo in histogram hover #4618 (comment)

[archmoj]

ping @emmanuelle

[archmoj]

💃