expose parcoords context line color #4635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/traces/parcoords/attributes.js
Outdated
| }, | ||
| editType: 'calc' | ||
| }, | ||
| editType: 'calc' |
Collaborator
There was a problem hiding this comment.
if color has editType: 'plot' and it's the only thing in these containers, they can have 'plot' as well.
Contributor
Author
There was a problem hiding this comment.
I recall, Etienne mentioned that for containers we should use calc.
Collaborator
There was a problem hiding this comment.
I believe containers should use the most intense editType of anything inside them, and should use calc if there's any array or arrayOk attribute inside.
Contributor
Author
There was a problem hiding this comment.
Thanks for the note regarding arrayOk items.
Changed all to plot in b4dabb2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3939 | Demo
by adding new attribute
unselected.line.color.TODO:
@plotly/plotly_js
cc: @chriddyp