-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Implement hovertemplate for candlestick and ohlc traces
#7619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
camdecoster
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we discussed, there's an issue with implementing the split: true logic that makes the split hover info not show up. Could you look into that?
Co-authored-by: Cameron DeCoster <cameron.decoster@gmail.com>
Co-authored-by: Cameron DeCoster <cameron.decoster@gmail.com>
6c901b2 to
cd1f39e
Compare
|
@camdecoster The bug you found with |
cd1f39e to
6800433
Compare
camdecoster
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Could you please add a draftlog before merging?
54bce31 to
fb6e114
Compare
Closes #3437
This PR adds a
hovertemplateattribute forohlcandcandlestick, allowing users to define a custom hover template for those traces.Notes
The first commit of this PR runs the biome formatter which introduces some noise into the diff. Use this link to see only the meaningful changes.
This PR also adds the
hovertemplatefallbackattribute for the two traces in questionhovertemplateis ignored whenhoverlabel.splitis set totrue. (Open to suggestions here but I couldn't see an obvious way to makesplit: truework with thehovertemplateAPI.)Two Jasmine tests added
This completes the list in #3437.
Thanks to @chriddyp for putting this on my radar!
To test
hoverlabel.splitis set totrue, the hovertemplate is ignored and the previous behavior is unchanged