Skip to content

Conversation

@camdecoster
Copy link
Contributor

@camdecoster camdecoster commented Nov 12, 2025

Description

Update topojson build script to generate a list of ISO country codes.

Closes #7621.

Changes

  • Update build script
  • Update info related to disputed territories

Testing

  • Be on this branch
  • In a terminal, cd into the topojson folder
  • Run npm run build (this could take a bit to download the required files)
  • Check the resulting list in the dist folder and make sure it includes the name and ISO code
  • Open the countries map (topojson/build/geojson/un_geodata_simplified_50m/countries.geojson) in Mapshaper and run the following command in the console: -filter '["XBT", "XHT", "XAC", "XAP", "XIT"].includes(iso3cd)'
  • Verify that there are 5 polygons and that they include the following disputed territories:
    • Ilemi Triangle
    • Halaib Triangle
    • Bir Tawil
    • Aksai Chin
    • Arunachal Pradesh

Notes

  • Since the maps are being updated, these will need to be included in the next plotly.js release

TODO

  • Add draftlog

@camdecoster camdecoster requested a review from emilykl November 12, 2025 19:01
@emilykl
Copy link
Contributor

emilykl commented Nov 12, 2025

@camdecoster What is the impact of this change? (Could you open an issue? 😉 )

@camdecoster
Copy link
Contributor Author

I created #7621 but forgot to add it to the OP. I updated it.

@emilykl
Copy link
Contributor

emilykl commented Nov 12, 2025

@camdecoster This has no impact on the library itself, correct?

@camdecoster
Copy link
Contributor Author

That's correct. The impact will come when we include the new maps in the next release.

Copy link
Contributor

@emilykl emilykl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@camdecoster camdecoster merged commit 98c69f2 into master Nov 12, 2025
5 of 6 checks passed
@camdecoster camdecoster deleted the cam/7621/build-list-iso-country-codes branch November 12, 2025 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE]: Generate list ISO country codes (and country names) during topojson build process

3 participants