layout is masked from ‘package:graphics’

[talgalili]

I just noticed that there is a plotly::layout function. This is a recipe for clashes with other packages which use graphics (in their DESCRIPTION) as depends (instead of as import).
I just had this clash between plotly and gplots.

I think the function should be renamed (maybe layout_ly or something like that), or be hidden from the global environment.

p.s.: I am surprised this didn't come up on CRAN. Packages should avoid masking functions from the base R packages as much as possible.

With regards,
Tal

[talgalili]

@cpsievert
I see you're fixing many things on plotly. Any chance to give this a look?

[cpsievert]

I agree, it was a mistake, but at this point, I think the breaking changes outweigh the benefits

[talgalili]

I think it could be solved (probably without breaking anything) by turning it into S3. For example:

# first you'll need to move layout to some other name
layout_ly <- plotly:::layout
 # i.e.: rename the function. Not actually assign it, as I am doing here

And then use:

layout <- function (p, ...) {
     UseMethod("layout")
}

layout.default <- function(p, ...) {
# you may wish to add some code here in case someone wishes to use mat explicitly and not mention p in any way. So this would need to be fixed - the question is if you think this direction would solve the isse.
     graphics::layout(mat=p, ...)
}

layout.plotly<- function(p, ...) {
     plotly::layout_ly(p=p, ...)
}

What do you think?

[cpsievert]

Hmm, interesting, I'll reopen and give it some more thought

[talgalili]

Thanks.

I used a similar trick in dendextend for dealing with cutree (I wanted to have a cutree.dendrogram and created a cutree.hclust from stats::cutree). See line 691:
https://github.com/talgalili/dendextend/blob/master/R/cutree.dendrogram.R

[timelyportfolio]

I think this would be a good approach. @cpsievert, let me know if you want me to explore it.

[cpsievert]

Closed via d2bf2a1. Let us know if you're still having problems, thanks!

[talgalili]

Great, thanks :)