foldIndex and Key props for Folds seems like an anti-pattern

[bpostlethwaite]

          <AxesFold name={_('Range')} foldIndex={1} key={1}>

Before we could move blocks of JSX around and they would still work. Now if you move Folds around you have to update foldIndex and key. That seems like a fairly significant regression.

Any other way?????
@VeraZab @nicolaskruchten @aulneau

[nicolaskruchten]

We could give them non-sequential keys, for one thing

…

On Wed, Jan 10, 2018 at 18:42 Ben Postlethwaite ***@***.***> wrote: <AxesFold name={_('Range')} foldIndex={1} key={1}> Before we could move blocks of JSX around and they would still work. Now if you move Folds around you have to update foldIndex and key. That seems like a fairly significant regression. Any other way????? @VeraZab <https://github.com/verazab> @nicolaskruchten <https://github.com/nicolaskruchten> @aulneau <https://github.com/aulneau> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#223>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAMbA5y88jCy5UIGNga1_KyOUuWOee_4ks5tJUrvgaJpZM4RaHLZ> .

[nicolaskruchten]

I.e. Strings :)

…

On Wed, Jan 10, 2018 at 20:02 Nicolas Kruchten ***@***.***> wrote: We could give them non-sequential keys, for one thing On Wed, Jan 10, 2018 at 18:42 Ben Postlethwaite ***@***.***> wrote: > <AxesFold name={_('Range')} foldIndex={1} key={1}> > > Before we could move blocks of JSX around and they would still work. Now > if you move Folds around you have to update foldIndex and key. That > seems like a fairly significant regression. > > Any other way????? > @VeraZab <https://github.com/verazab> @nicolaskruchten > <https://github.com/nicolaskruchten> @aulneau > <https://github.com/aulneau> > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <#223>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/AAMbA5y88jCy5UIGNga1_KyOUuWOee_4ks5tJUrvgaJpZM4RaHLZ> > . >

[bpostlethwaite]

That is an improvement. Is there no way for this to be handled automagically? We'll strings if nit. Can someone slamo that in real quick?

[nicolaskruchten]

I've been thinking about it and nothing obvious comes to mind. Time to think harder about non-obvious things!

[bpostlethwaite]

Sorry that previous comment was autocorrected into obscurity. I'll leave it as is an an amusement.

[bpostlethwaite]

Oh seriously. I'll get my laptop on WiFi.

[bpostlethwaite]

I am having troubles even adding foldIndexes in a large file. It's hard to keep track of which fold number you should be adding at some particular screenful of code

[VeraZab]

see #226 @bpostlethwaite