3d #308
3d #308
Conversation
| <TraceAccordion> | ||
| <Section name={_('Trace')} attr="name"> | ||
| <TextEditor label={_('Name')} attr="name" richTextOnly /> | ||
| <TraceOrientation |
There was a problem hiding this comment.
explanation:
that rule that requires for the first section in a fold to have an attribute for the fold to display, it doesn't work for for choropleths.
Those traces don't have 'opacity' and 'orientation' attributes. So an empty 'Trace' header section shows up for those trace types.
Previously trace.name was in that section, so that was fine, all traces can have names. But now trace.name is in the create panel, which looks good, but it looks like it's hard to find an attribute that exists on all traces.
So I'm adding trace.name to the Trace Style panel, so that we don't break the above rule and that the panel looks good for all traces.
There was a problem hiding this comment.
Sounds good. Makes sense to have the name panel in both places anyway IMO. The other option would be to remove the attr="name" prop from the Section and then it'll not appear if it's empty.
There was a problem hiding this comment.
yeah, I was going to say that if I remove the attr="name" then the panel's empty, and then I looked and saw that none of our other sections have an attr.
Well, I'll keep it in both places for now.
|
💃 |
styling control adjustments for 3d
projection.{x|y|z}anderror_{x|y|z}, will be done in axes