Fix package.json for consumers

[gnestor]

This moves react and react-dom from dependencies to peerDependencies and devDependencies. This prevents multiple copies of react from being loaded by consumer apps.

The same needs to be done for plotly-icons: plotly/plotly-icons#14

When that's merged, we can change the:

"plotly-icons": "github:gnestor/plotly-icons#package.json",

line to:

"plotly-icons": "latest",

[nicolaskruchten]

This makes sense to me. I didn't realize you could have modules in both peerDeps and devDeps.

[nicolaskruchten]

@VeraZab let's get this and the icons one merged in before the next release

[VeraZab]

thanks @gnestor I'll make a release for plotly-icons now and then we can change this in your pr and then merge

[VeraZab]

ok, plotly-icons 1.1.5 is out, we can make changes here for it, then merge this :) thanks!

[gnestor]

@VeraZab Ok, I updated this branch 👍

[nicolaskruchten]

💃 once this passes CI.

[nicolaskruchten]

Ah, perhaps CI doesn't run on external repos? I'm OK to merge this @VeraZab

[VeraZab]

yes @nicolaskruchten ok to merge. there's no conflicts in package.json right?

[gnestor]

Github should warn you if there are merge conflicts. It looks mergeable to me. I rebase this to master yesterday 👍

[nicolaskruchten]

This is what the UI looks like in github for us now:

[gnestor]

Ok, check now 👍

[nicolaskruchten]

Hehe thanks, but in the meantime I submitted the same changes in a separate PR so they could hit master faster. There's something about our branch-protection setup which is making things hard for cross-repo PRs I think.

[gnestor]

Ok, in the future I'll try to submit PRs from branches on this repo (vs. a fork) 👍

[nicolaskruchten]

Thanks, and sorry, I'm not sure why this happens...