Skip to content

Conversation

@nicolaskruchten
Copy link
Contributor

@gnestor
Copy link

gnestor commented Mar 2, 2018

I'm running into a new error with this fix:

Uncaught TypeError: Cannot read property 'type' of undefined
    at Object.r.getTraceValObject (<anonymous>:7:1712492)
    at Object.getValObject (connectTraceToPlot.js:81)
    at unpackPlotProps (unpackPlotProps.js:35)
    at Function.supplyPlotProps (connectToContainer.js:71)
    at Fold.js:66
    at forEachSingleChild (react.development.js:858)
    at traverseAllChildrenImpl (react.development.js:762)
    at traverseAllChildrenImpl (react.development.js:778)
    at traverseAllChildren (react.development.js:833)
    at Object.forEachChildren [as forEach] (react.development.js:878)
    at Fold.determineVisibility (Fold.js:62)
    at new Fold (Fold.js:46)
    at constructClassInstance (react-dom.development.js:6355)
    at updateClassComponent (react-dom.development.js:7839)
    at beginWork (react-dom.development.js:8225)
    at performUnitOfWork (react-dom.development.js:10224)
    at workLoop (react-dom.development.js:10288)
    at HTMLUnknownElement.callCallback (react-dom.development.js:542)
    at Object.invokeGuardedCallbackDev (react-dom.development.js:581)
    at invokeGuardedCallback (react-dom.development.js:438)
    at renderRoot (react-dom.development.js:10366)
    at performWorkOnRoot (react-dom.development.js:11014)
    at performWork (react-dom.development.js:10967)
    at batchedUpdates (react-dom.development.js:11086)
    at batchedUpdates (react-dom.development.js:2330)
    at dispatchEvent (react-dom.development.js:3421)

@nicolaskruchten
Copy link
Contributor Author

OK this feels a bit like whack-a-mole but if you could try this updated patch I'd be grateful as I can't seem to wire it up on my end. Clearly for some reason within the Jupyter context something is being rendered in a different order from the way it gets done elsewhere. These extra checks should prevent that render from erroring out, and then on the next one things render as they should. It's a bit weird but I've successfully gotten this pattern working elsewhere in the editor so once enough guards are in place it should work :)

@VeraZab
Copy link
Contributor

VeraZab commented Mar 5, 2018

💃

@nicolaskruchten nicolaskruchten merged commit c552309 into master Mar 5, 2018
@nicolaskruchten nicolaskruchten deleted the jupyter_fix branch March 5, 2018 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants