dev tools for JSON #411
Merged
dev tools for JSON #411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VeraZab
reviewed
Mar 14, 2018
| onDelete={({updated_src}) => this.setState(updated_src)} | ||
| src={{ | ||
| data: this.state.data, | ||
| layout: this.state.layout, |
Contributor
Author
|
I didn't think it was important to edit frames/config in dev... but sure we
can add them easily enough
…On Wed, Mar 14, 2018 at 16:27 VeraZab ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In dev/App.js
<#411 (comment)>
:
> + >
+ {' '}
+ <DefaultEditor>
+ <Panel group="Dev" name="JSON">
+ <ReactJson
+ enableClipboard={false}
+ name={false}
+ displayDataTypes={false}
+ displayObjectSize={false}
+ indentWidth={2}
+ onAdd={({updated_src}) => this.setState(updated_src)}
+ onEdit={({updated_src}) => this.setState(updated_src)}
+ onDelete={({updated_src}) => this.setState(updated_src)}
+ src={{
+ data: this.state.data,
+ layout: this.state.layout,
frames
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#411 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAMbA8cqphsHNbjA-z9YqJej5l9P7ON3ks5teX0ygaJpZM4SrHLf>
.
|
Contributor
Author
|
OK done, plus I got rid of the nav thing and hid it in the dev panel, to recover some real-estate. The dev app now suffers from the "tiny plot on load" problem, which is good, it'll force us to fix it for good! |
Contributor
|
nice!! 💃 thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.