Rename Panel/Fold/Section -> PlotlyPanel/Fold/Section/ #432
Conversation
VeraZab
force-pushed
the
plotly-containers
branch
from
94fda9b to
3b47567
Compare
VeraZab
changed the title
VeraZab
force-pushed
the
plotly-containers
branch
4 times, most recently
from
0a25da3 to
93d9bac
Compare
| className: PropTypes.string, | ||
| folded: PropTypes.bool, | ||
| toggleFold: PropTypes.func, | ||
| hideHeader: PropTypes.bool, |
There was a problem hiding this comment.
I removed the isRequired here...
BUT, I am testing in my tests that those props are there for <Fold/>s
I don't know why those console.errors were occurring..
| Panel.propTypes = { | ||
| PlotlyPanel.propTypes = { | ||
| children: PropTypes.node, | ||
| addAction: PropTypes.object, |
There was a problem hiding this comment.
I left the addAction on <Panel/> maybe devs would like to add some non context related addActions..
Doesn't have to be disabled no?
|
|
||
| SectionHeader.propTypes = { | ||
| name: PropTypes.string, | ||
| }; |
There was a problem hiding this comment.
we don't need this anymore.. also Ben didn't use it in his code :)
| return ( | ||
| <Field {...this.props}> | ||
| <div className="js-test-info">{this.props.children}</div> | ||
| </Field> |
There was a problem hiding this comment.
If I add the class on Field, it gives me 2 js-test-info classes, one on the localized wrapper one on Field
VeraZab
force-pushed
the
plotly-containers
branch
from
93d9bac to
473351a
Compare
|
@nicolaskruchten would you take a 👀 |
VeraZab
force-pushed
the
plotly-containers
branch
from
4c4785f to
52109c5
Compare
| export default class PlotlyPanel extends Panel {} | ||
| export const Panel = localize(UnlocalizedPanel); | ||
|
|
||
| export default class PlotlyPanel extends UnlocalizedPanel {} |
There was a problem hiding this comment.
that's weird... the Panel and Section were not localized but the Fold was ???
|
💃 thanks for putting up with these requirements and changes :) |
fixes: #403