clean up trace selector #455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nicolaskruchten
commented
Apr 27, 2018
nicolaskruchten
commented
- Localize and rename modal to say Trace instead of Chart
- Remove HeatmapGL as per plotly.js team update
- Standardize scatter polar labelling
- Moving Specialized left so as to make it clearer that the Polar Scatter GL is an optimized version of Polar (i.e. the "X GL" are all to the right of the corresponding "X")
Contributor
oh, that doesn't make it so there's too many basic trace types? |
Contributor
Author
|
No, I just swapped the position of financial and specialized, I didn't move anything from one box to another. |
Contributor
|
ok :) i'll trust it looks good 💃 |
Contributor
Author
|
|
Contributor
Author
|
Looks much the same :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.