-
-
Notifications
You must be signed in to change notification settings - Fork 114
Adjust array src format + add transposition logic #471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a8d9506 to
046ecef
Compare
| if ( | ||
| this.is2D && | ||
| this.fullValue && | ||
| this.fullValue.length && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
guards against empty arrays
| if (config.deleteKeys && !(srcRef in dataSources)) { | ||
| delete parent[dataKey]; | ||
| return; | ||
| // making this into an array to more easily lookup 1d and 2d srcs in dataSourceOptions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's easier to have this in an array format to lookup srcs in dataOptions, this behaviour here was broken in current dereferencing function for array srcs
|
@bpostlethwaite ready for review |
|
OK so on the src-handling front, the API is a bit murky for me... Right now we expect |
|
I would also have those functions be distinct props, rather than keys in an opaque-looking |
|
Thanks @nicolaskruchten ! Made the adjustments. I think I like keeping the It's ready for a second look when you have a chance. |
2945268 to
b62cf33
Compare
|
💃 from me on the high-level API. The tests seem good to me. |
|
sorry, hit wrong button :) |
b62cf33 to
cf5c799
Compare
No description provided.