Fit transform adjustments #493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (this.props.beforeAddTrace) { | ||
| this.props.beforeAddTrace(payload); | ||
| } | ||
| graphDiv.data.push({type: 'scatter', mode: 'markers'}); |
Contributor
There was a problem hiding this comment.
what's the reasoning for this change?
Contributor
Author
There was a problem hiding this comment.
a fit is a new trace in the data array, so I need to be able to have the new trace be something other than 'scatter', to do something like:
const addAction = {
label: _('Fit'),
handler: (context) => {
const value = {
transforms: [{
inputUid,
type: 'fit',
fitfunction: 'm*x + b'
}]
};
if (context.onUpdate) {
context.onUpdate({
type: EDITOR_ACTIONS.ADD_TRACE,
payload: value
});
}
},
};
Contributor
There was a problem hiding this comment.
if you're actually not using this, let's revert it :)
Contributor
|
💃 |
VeraZab
force-pushed
the
fit-transform-adjustments
branch
8 times, most recently
from
b150881 to
29e768f
Compare
VeraZab
force-pushed
the
fit-transform-adjustments
branch
3 times, most recently
from
d15b9d6 to
ab0c24a
Compare
Contributor
Author
|
ok @nicolaskruchten this is ready for another review |
| .numeric-input__wrapper { | ||
| line-height: 20px; | ||
| max-width: 100%; | ||
| width: 100%; |
Contributor
There was a problem hiding this comment.
this causes some visual diffs in Percy that don't seem awesome...
Contributor
|
You'll have to walk me through some of these changes :) |
| render() { | ||
| const {data = [], localize: _} = this.context; | ||
| const {canAdd, canGroup, children, messageIfEmptyFold} = this.props; | ||
| const {canAdd, canGroup, children, messageIfEmptyFold, panel} = this.props; |
Contributor
There was a problem hiding this comment.
I would recommend changing panel to excludeFits or something as a boolean, just to match canAdd and canGroup
VeraZab
force-pushed
the
fit-transform-adjustments
branch
3 times, most recently
from
ee5d420 to
1a70a03
Compare
VeraZab
force-pushed
the
fit-transform-adjustments
branch
from
1a70a03 to
d860655
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.