Try customTraces in Dev #502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VeraZab
force-pushed
the
dev-custom-traces
branch
3 times, most recently
from
ff12e57 to
fbbe373
Compare
Contributor
Author
|
This should work now when configured and when not configured. |
dev/App.js
Outdated
| 'histogram2d' | ||
| ].includes(t.value) | ||
| )).map(t => { | ||
| t.category = chartCategory(_).SIMPLE |
Contributor
There was a problem hiding this comment.
let's remove this if it's not needed
src/EditorControls.js
Outdated
| plotly: PropTypes.object, | ||
| showFieldTooltips: PropTypes.bool, | ||
| traceTypesConfig: PropTypes.object, | ||
| useGLDefault: PropTypes.bool, |
Contributor
There was a problem hiding this comment.
I would have this be a full object, called defaultInitialTrace or something, so that we could have bar by default if we wanted.
Contributor
|
OK so can we split this into two commits: one that's intended to be merged, and one that's just demo of how to use it? :) |
VeraZab
force-pushed
the
dev-custom-traces
branch
3 times, most recently
from
3958f98 to
bb194bf
Compare
src/EditorControls.js
Outdated
| graphDiv.data.push( | ||
| this.props.useAsDefaultTrace | ||
| ? this.props.useAsDefaultTrace | ||
| : {type: 'scatter', mode: 'markers'} |
Contributor
There was a problem hiding this comment.
can this just be the default value for the prop instead?
Contributor
|
💃 for the first commit once default values used |
VeraZab
force-pushed
the
dev-custom-traces
branch
from
d5f2462 to
ea2d775
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #500
cc @nicolaskruchten