Marker size multivalue #586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmt0
force-pushed
the
marker-size-multivalue
branch
2 times, most recently
from
c81a654 to
29bb7ec
Compare
dmt0
force-pushed
the
marker-size-multivalue
branch
from
29bb7ec to
97f84c7
Compare
Contributor
Author
|
This one's ready |
| fromVal = fromObj[key]; | ||
|
|
||
| var searchArrays = config.searchArrays; | ||
| const intoVal = intoObj[key]; |
Contributor
There was a problem hiding this comment.
nice fixes in this file.
| if (isNumeric(value)) { | ||
| if (direction === 'increase') { | ||
| valueUpdate = value + step; | ||
| valueUpdate = parseFloat(value) + step; |
Contributor
There was a problem hiding this comment.
man, can't believe we didn't have worse bugs before
Contributor
|
So why is the slider for opacity all-blue now? In general the sliders are blue on the left, grey on the right so if the thingy is all the way to the left, it should be all-grey no? strange that it would change like this? |
Contributor
|
💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #579
also fixes a bug where incrementing size in numericals does 6+1=61 (yay javascript!)