correct hoveron options for each trace type #666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VeraZab
reviewed
Aug 9, 2018
| } | ||
|
|
||
| if (container.type === 'choropleth') { | ||
| } else if (container.type === 'choropleth') { |
Contributor
There was a problem hiding this comment.
did you change this to else if because the same trace type was present in more than one conditional?
Contributor
Author
There was a problem hiding this comment.
I did it for performance, so that if it hits one, it falls through.
After your last update, when I split a trace into 17 traces and tried to load StyleTracePanel - oh my - that MBP with 16GB ram had to really run for the money :)
dmt0
force-pushed
the
hoveron-options
branch
4 times, most recently
from
b171165 to
77a7521
Compare
Contributor
|
ok looks good to me 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #576