localize subplot names #687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looking good, nice refactoring/localization! Small things:
|
dmt0
force-pushed
the
localize-subplots
branch
from
a6c986e to
9ae6759
Compare
dmt0
force-pushed
the
localize-subplots
branch
from
9ae6759 to
2529960
Compare
| } | ||
| }); | ||
|
|
||
| let pieCounter = 0; |
Contributor
There was a problem hiding this comment.
hehe OK, we'll refactor that next time, when we add a third :)
Contributor
Author
There was a problem hiding this comment.
that's what I was thinking when I was writing it lol
Contributor
|
💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #665
addresses #631