Skip to content

Histogram options #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 27, 2018
Merged

Histogram options #713

merged 2 commits into from
Aug 27, 2018

Conversation

@dmt0
Copy link
Contributor

@dmt0 dmt0 commented Aug 27, 2018

closes #599

  • update packages

@dmt0 dmt0 force-pushed the histogram-options branch from f9fb978 to 5897ff6 Compare August 27, 2018 19:11
@dmt0 dmt0 force-pushed the histogram-options branch from 5897ff6 to 8c7f873 Compare August 27, 2018 19:20
@dmt0 dmt0 self-assigned this Aug 27, 2018
nicolaskruchten
nicolaskruchten reviewed Aug 27, 2018
View reviewed changes
src/default_panels/GraphCreatePanel.js Outdated
<HistogramInfoVertical>
{_('Note: in vertical orientation, X values are used for bins and Y values for weights.')}
{_(
'Note: in vertical orientation, X values are used for bins and Y values for weights. You can configure the binning function in the '
Copy link
Contributor

@nicolaskruchten nicolaskruchten Aug 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wordsmithing ... :) "... X values are used for binning. If Y values are provided, they are used as inputs to the histogram function which you can configure in the Traces panel. If Y values are omitted, the histogram function defaults to Count."

Also please rename "binning function" to "histogram function" in the Traces panel.

Copy link
Contributor

@nicolaskruchten nicolaskruchten Aug 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also: please move the "histogram function" outside of the "binning" section, right below normalization.

Copy link
Contributor Author

@dmt0 dmt0 Aug 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@dmt0 dmt0 force-pushed the histogram-options branch from 8c7f873 to 2a6d2ce Compare August 27, 2018 19:50
@nicolaskruchten
Copy link
Contributor

nicolaskruchten commented Aug 27, 2018

can you move the histogram function too plz ?

when that's done, 💃

@dmt0 dmt0 force-pushed the histogram-options branch from 2a6d2ce to f75c013 Compare August 27, 2018 20:59
@dmt0 dmt0 merged commit 98313ec into master Aug 27, 2018
@dmt0 dmt0 deleted the histogram-options branch August 27, 2018 21:06
@nicolaskruchten
Copy link
Contributor

nicolaskruchten commented Aug 28, 2018

Hmmm I think the updated packages are a step too far here... I have to use node 10 now? Does that work on streambed?

Note also that even with node 10 I can't get yarn install to work.

nk$ rm -rf node_modules                                                                     ~p/react-chart-editor [mapbox-fixes]
nk$ yarn                                                                                    ~p/react-chart-editor [mapbox-fixes]
yarn install v1.9.2
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
error eslint@5.4.0: The engine "node" is incompatible with this module. Expected version "^6.14.0 || ^8.10.0 || >=9.10.0".
error Found incompatible module
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
nk$ nvm use 9                                                                               ~p/react-chart-editor [mapbox-fixes]
Now using node v9.11.1 (npm v5.6.0)
nk$ yarn                                                                                    ~p/react-chart-editor [mapbox-fixes]
yarn install v1.9.2
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
error postcss-combine-duplicated-selectors@6.0.2: The engine "node" is incompatible with this module. Expected version "^6.0.0 || ^8.0.0 || >=10.0.0".
error Found incompatible module
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
nk$ nvm use 10                                                                              ~p/react-chart-editor [mapbox-fixes]
Now using node v10.6.0 (npm v6.1.0)
nk$ yarn                                                                                    ~p/react-chart-editor [mapbox-fixes]
yarn install v1.9.2
[1/4] 🔍  Resolving packages...
[2/4] 🚚  Fetching packages...
[-----------------------------------------------------------------------------------------------------------------------] 0/1695(node:91411) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
[3/4] 🔗  Linking dependencies...
warning " > @plotly/draft-js-export-html@1.2.0" has unmet peer dependency "immutable@3.x.x".
warning " > draft-js-utils@1.2.0" has unmet peer dependency "immutable@3.x.x".
warning " > draft-js-import-html@1.2.1" has unmet peer dependency "immutable@3.x.x".
warning "draft-js-import-html > draft-js-import-element@1.2.1" has unmet peer dependency "immutable@3.x.x".
warning " > react-rangeslider@2.2.0" has incorrect peer dependency "react@^0.14.0 || ^15.0.0".
warning "@percy/react > @percy/react-percy-ci > @percy/react-percy-snapshot-render@0.4.1" has incorrect peer dependency "react@^15.4.0".
warning "@percy/react > @percy/react-percy-ci > @percy/react-percy-snapshot-render@0.4.1" has incorrect peer dependency "react-dom@^15.4.0".
warning " > css-loader@1.0.0" has incorrect peer dependency "webpack@^4.0.0".
[4/4] 📃  Building fresh packages...
[-/5] ⢀ waiting...
[-/5] ⢀ waiting...
[3/5] ⢀ fsevents
[4/5] ⢀ gl
error /Users/nicolas/plotly/react-chart-editor/node_modules/gl: Command failed.
Exit code: 1
Command: prebuild-install || node-gyp rebuild
Arguments:
Directory: /Users/nicolas/plotly/react-chart-editor/node_modules/gl
Output:
prebuild-install WARN install No prebuilt binaries found (target=10.6.0 runtime=node arch=x64 platform=darwin)

@nicolaskruchten nicolaskruchten mentioned this pull request Aug 28, 2018
Merged
@nicolaskruchten
Copy link
Contributor

nicolaskruchten commented Aug 28, 2018

OK I got it to run with a more recent 8.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VeraZab VeraZab Awaiting requested review from VeraZab

1 more reviewer

@nicolaskruchten nicolaskruchten nicolaskruchten left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@dmt0 dmt0

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2d histogram options

3 participants

@dmt0 @nicolaskruchten