Skip to content

Examples fixes #727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 31, 2018
Merged

Examples fixes #727

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d2fbb9f
don't show trace selector actions if they don't exist
dmt0 Aug 31, 2018
2c24945
space under last single item in sidebar
dmt0 Aug 31, 2018
347578e
fix subplot deletion
dmt0 Aug 31, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/fields/SubplotCreator.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,15 +35,15 @@ class UnconnectedSingleSubplotCreator extends Component {
}

updateSubplot(update) {
const currentSubplotId = this.props.fullContainer[SUBPLOT_TO_ATTR[this.props.attr].data];
const currentSubplotId = this.props.fullContainer[SUBPLOT_TO_ATTR[this.props.layoutAttr].data];
let subplotToBeGarbageCollected = null;

// When we select another subplot, make sure no unused axes are left
if (
currentSubplotId !== update &&
!this.context.fullData.some(
trace =>
trace[SUBPLOT_TO_ATTR[this.props.attr].data] === currentSubplotId &&
trace[SUBPLOT_TO_ATTR[this.props.layoutAttr].data] === currentSubplotId &&
trace.index !== this.props.fullContainer.index
)
) {
Expand Down
7 changes: 6 additions & 1 deletion src/components/widgets/TraceTypeSelector.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ class TraceTypeSelector extends Component {
label: _('Charts like this by Plotly users.'),
onClick:
chartHelp[value] &&
chartHelp[value].feedQuery &&
(e =>
onClick(e, () =>
window.open(
Expand All @@ -120,12 +121,16 @@ class TraceTypeSelector extends Component {
label: _('View tutorials on this chart type.'),
onClick:
chartHelp[value] &&
chartHelp[value].helpDoc &&
(e => onClick(e, () => window.open(chartHelp[value].helpDoc, '_blank'))),
icon: <ThumnailViewIcon />,
},
{
label: _('See a basic example.'),
onClick: chartHelp[value] && (e => onClick(e, chartHelp[value].examplePlot)),
onClick:
chartHelp[value] &&
chartHelp[value].examplePlot &&
(e => onClick(e, chartHelp[value].examplePlot)),
icon: <GraphIcon />,
},
];
Expand Down
3 changes: 3 additions & 0 deletions src/styles/components/sidebar/_main.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,9 @@

&--single {
margin-top: 15px;
&:last-child {
margin-bottom: 15px;
}
}

&::before {
Expand Down
8 changes: 5 additions & 3 deletions src/styles/components/widgets/_trace-type-selector.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
$item-size: 90px;
$image-size: 60px;

.trace-grid {
display: grid;
grid-template-columns: repeat(4, 1fr);
Expand Down Expand Up @@ -97,6 +99,7 @@ $item-size: 90px;
justify-content: flex-start;
align-items: flex-end;
z-index: 99;
height: $image-size;

&:hover {
.trace-item__actions__item {
Expand Down Expand Up @@ -139,10 +142,9 @@ $item-size: 90px;
&__image {
position: relative;
z-index: 2;
$size: 60px;
border: 1px solid var(--color-border-default);
width: $size;
height: $size;
width: $image-size;
height: $image-size;
border-radius: var(--border-radius);
background: var(--color-background-top);
box-shadow: 0 2px 9px transparent;
Expand Down