preset sizeref reasonably #772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VeraZab
reviewed
Oct 19, 2018
| update['marker.sizeref'] = size.reduce((a, b) => Math.max(a, b)) / 2000; | ||
| update['marker.sizemode'] = 'area'; | ||
| } | ||
| }; |
Contributor
There was a problem hiding this comment.
well, it seems like this is a good place to put that code in.
So we can never use size.mode diameter when there's a sizeref..?
Contributor
Author
There was a problem hiding this comment.
you can, you just have to set it yourself after. It's almost always the wrong thing to do tho, so I'm OK with forcing it back every time you switch that dropdown.
Contributor
|
this seems good, just question above.. |
nicolaskruchten
force-pushed
the
autosize
branch
from
2ee5417 to
728fcf9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #771