Skip to content

Conversation

@nicolaskruchten
Copy link
Contributor

Closes #768 when done...

@VeraZab @dmt0 it's actually kind of tricky to think about what the new trace should look like... should it reuse mode? orientation? Should it go through traceTypeToPlotlyInitFigure? Should it reuse everything except data arrays?

What did the old workspace do?

@VeraZab
Copy link
Contributor

VeraZab commented Oct 22, 2018

the old workspace copied the last trace exactly, with data and everything
i think that i would have copied everything except src related info, and used traceTypeToPlotlyInitFigure

@nicolaskruchten
Copy link
Contributor Author

Are you sure it copied everything? I seem to recall it only copied srcs for X and not Y for scatters for example... ?

@dmt0
Copy link
Contributor

dmt0 commented Oct 22, 2018

I'd just copy stuff that's under Structure/Traces panel, but does not involve data sources. Copying other stuff under data would have to be done on a case by case basis, and would get complicated.

@nicolaskruchten
Copy link
Contributor Author

how's this? :)

@VeraZab
Copy link
Contributor

VeraZab commented Oct 22, 2018

yup, that seems good to me!

@nicolaskruchten nicolaskruchten changed the title WIP reuse trace type reuse trace type Oct 22, 2018
@dmt0
Copy link
Contributor

dmt0 commented Oct 22, 2018

Create area, than add one more trace -> creates line

@dmt0
Copy link
Contributor

dmt0 commented Oct 22, 2018

💃

@nicolaskruchten nicolaskruchten merged commit f4b7b99 into master Oct 30, 2018
@nicolaskruchten nicolaskruchten deleted the trace_reuse branch October 30, 2018 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants