StyleGeoPanel #904
Merged
StyleGeoPanel #904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
let's get Percy up so I can see what this looks like! I'd like to see the Geo panel in percy if possible, with a mock that has 2 geos and a scatter... I'd expect to see just two subplot folds, right? one for each geo, but the scatter should be filtered out (which i'm not seeing any code for but maybe I just missed) |
dmt0
force-pushed
the
geo-panel
branch
5 times, most recently
from
2ff535f to
a2fa4ea
Compare
VeraZab
reviewed
Apr 11, 2019
VeraZab
reviewed
Apr 11, 2019
VeraZab
reviewed
Apr 11, 2019
Contributor
|
yeah, just wondering if that Legend behavior is good, otherwise 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #851
Also hide Legend if there are no traces with
showlegenddefined infullData