Add hoverlabel.namelength widget #905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
ready for review ✨ review @nicolaskruchten, although I posted about a possible bug in plotly_js channel |
Contributor
Author
|
Actually, I'm leaving this 'Hide' option in for now for hoverlabel.namelength, because under certain scenarios: like switching from a template mode, where the namelength was hidden, and going into 'Values' mode can leave user in a weird state, where the figure has the 'hidden' option selected but it does not show in the UI. And there's other usercases where switching around options can leave the user in a weird state. So I'm leaving all options for now. |
dmt0
reviewed
Apr 11, 2019
Contributor
|
Yay! 💃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #890
