Line chart performance issues with curve="basis" when upgraded to React 19 #2840
petrvecera
started this conversation in
General
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Hey guys
I have performance issues with linear chart when I have
curve=basis, when I witch tocurve=linearit's OK.The difference is render time 3s vs 500ms , I think that this started when I upgraded to React 19.
I tried to create reproducible example but I can't https://codesandbox.io/p/devbox/nivo-line-react-19-forked-sqj5xp?file=%2Fsrc%2FApp.tsx%3A20%2C5&workspaceId=ws_BgKKvSFP3wzupxpCsyigcP
The charts where I can reproduce this problem are here:
https://github.com/cohstats/coh3-stats/blob/master/screens/live-games/live-games-line-chart.tsx
https://github.com/cohstats/coh3-stats/blob/master/screens/stats/game/charts/games-percentage-line-chart-card.tsx#L96
If someone founds what is wrong, that would be super helpful 👍
Cheers
Beta Was this translation helpful? Give feedback.
All reactions