Conversation
Checking the exactly class of an object is bad practice. Check $obj->isa($class) instead. Using confess for a full stack trace on isa failure. die won't show where the actual attempt to set the attribute was made and croak will report somewhere in the middle of Moo.
This gives the user the option to use Cpanel::JSON::XS for fast JSON parsing instead of JSON::XS. JSON::XS is written by Marc Lehmann who is notoriously abusive to his users. See https://rt.cpan.org/Ticket/Display.html?id=100031
|
Changes Unknown when pulling 06ded5d on refactor/change_JSON into * on master*. |
|
\o/ |
Owner
|
Thanks :)! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The maintainer of JSON::XS is not someone you ever want to interact with. JSON::MaybeXS prefers Cpanel::JSON::XS before JSON::XS which allows people to remove JSON::XS from their stack.
For https://rt.cpan.org/Ticket/Display.html?id=100031