Skip to content

Fix(fields): rely on input first #920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 26, 2025
Merged

Fix(fields): rely on input first #920

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3853453
Fix(fields): rely on input first
stonebuzz Feb 5, 2025
0beb97d
adpat changelog
stonebuzz Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,21 @@ and this project adheres to [Semantic Versioning](http://semver.org/).

## [UNRELEASE]

### Fixed

- Fix container update from other context (like plugins)

## [1.21.19] - 2025-02-03

### Fixed

- Fix container update from `API`
- Fix: fix default value for `dropdown` field to avoid empty dropdown

## [1.21.18] - 2024-01-16

### Fixed

- Fix `PluginFieldsContainerDisplayCondition` display when value is no more available.
- Fix issue where the value of custom fields could not be saved

Expand Down
6 changes: 3 additions & 3 deletions inc/container.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1664,10 +1664,10 @@ public static function preItemUpdate(CommonDBTM $item)
public static function preItem(CommonDBTM $item)
{
//find container (if not exist, do nothing)
if (isset($_REQUEST['c_id'])) {
$c_id = $_REQUEST['c_id'];
} elseif (isset($item->input['c_id'])) {
if (isset($item->input['c_id'])) {
$c_id = $item->input['c_id'];
} elseif (isset($_REQUEST['c_id'])) {
$c_id = $_REQUEST['c_id'];
} else {
$type = 'dom';
if (isset($_REQUEST['_plugin_fields_type'])) {
Expand Down