Fix number search option

[Lainow]

Checklist before requesting a review

Please delete options that are not relevant.

• I have performed a self-review of my code.
• I have added tests (when available) that prove my fix is effective or that my feature works.
• I have updated the CHANGELOG with a short functional description of the fix or new feature.
• This change requires a documentation update.

Description

• It fixes !36664
• Here is a brief description of what this PR does
  Fix the ability to search on 'number' fields

Before :

After :

Screenshots (if appropriate):

[stonebuzz]

seems a revert of

#857

Can you check whether the issue raised by this PR (857) is actually fixed with it?

[Lainow]

seems a revert of

#857

Can you check whether the issue raised by this PR (857) is actually fixed with it?

Yes, the problem has been solved

[stonebuzz]

Can you validate with customer ?

[stonebuzz]

After some tests,

can you reset all changes and just apply this

diff --git a/hook.php b/hook.php
index 2ee27aa..91e041b 100644
--- a/hook.php
+++ b/hook.php
@@ -344,9 +344,32 @@ function plugin_fields_addWhere($link, $nott, $itemtype, $ID, $val, $searchtype)
     $searchopt = &Search::getOptions($itemtype);
     $table     = $searchopt[$ID]['table'];
     $field     = $searchopt[$ID]['field'];
+    $pfields_type = $searchopt[$ID]['pfields_type'] ?? '';
 
     $field_field = new PluginFieldsField();
 
+
+
+    if (
+        $field_field->getFromDBByCrit(
+            [
+                'name'     => $field,
+                'type' => 'number',
+            ],
+        )
+        && $pfields_type == 'number'
+    ) {
+        // if 'number' field with name is found with searchtype 'equals' or 'notequals'
+        // surround with with qote desired value
+        // database column is delcared as varchar while GLPI search use number
+        // prevent Truncated incorrect DECIMAL value: ''
+        // where some line are NULL or '' value in related column
+        if ($searchtype == 'equals' || $searchtype == 'notequals') {
+            $operator = ($searchtype == 'equals') ? '=' : '!=';
+            return $link . $DB->quoteName("$table" . '_' . "$field") . '.' . $DB->quoteName($field) . $operator . ' ' . $DB->quoteValue($val) ;
+        }
+    }
+
     // if 'multiple' field with name is found -> 'Dropdown-XXXX' case
     // update WHERE clause with LIKE statement
     if (
diff --git a/inc/container.class.php b/inc/container.class.php
index eb6712e..e0710f6 100644
--- a/inc/container.class.php
+++ b/inc/container.class.php
@@ -1963,6 +1963,7 @@ HTML;
                     break;
                 case 'number':
                     $opt[$i]['datatype'] = 'decimal';
+                    $opt[$i]['searchtype'] = ['contains', 'notcontains', 'equals', 'notequals'];
                     break;
                 case 'date':
                 case 'datetime':

[stonebuzz]

@Lainow can you rebase ?

[Lainow]

Ok for customer