Skip to content

fix(searchOption): notequals operator returns equals values for multiple dropdown #928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 20, 2025
Merged

fix(searchOption): notequals operator returns equals values for multiple dropdown #928

merged 7 commits into from
Mar 20, 2025

Conversation

@MyvTsv
Copy link
Contributor

@MyvTsv MyvTsv commented Mar 13, 2025 •
edited
Loading

  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.
  • I have updated the CHANGELOG with a short functional description of the fix or new feature.
  • This change requires a documentation update.

Description

  • It fixes !36795
  • The operator is not had the same behavior as the operator is in the search options for multiple choice dropdown

Capture d’écran du 2025-03-14 10-09-00

Capture d’écran du 2025-03-14 10-09-57

@MyvTsv MyvTsv self-assigned this Mar 13, 2025
@MyvTsv MyvTsv requested review from Rom1-B and stonebuzz March 13, 2025 12:32
stonebuzz
stonebuzz requested changes Mar 14, 2025
View reviewed changes
MyvTsv and others added 3 commits March 14, 2025 09:35
@MyvTsv @stonebuzz
Update hook.php
0219d64 
Co-authored-by: Stanislas <skita@teclib.com>
@MyvTsv
verif not condition
9fedbce
@MyvTsv
lint
1d47324
@MyvTsv MyvTsv requested a review from stonebuzz March 14, 2025 09:00
@MyvTsv MyvTsv marked this pull request as ready for review March 14, 2025 09:05
stonebuzz
stonebuzz requested changes Mar 17, 2025
View reviewed changes
@stonebuzz
Copy link
Contributor

stonebuzz commented Mar 17, 2025

Hi @MyvTsv
can you validate with customers ?

Best regards

@MyvTsv @stonebuzz
Update CHANGELOG.md
00660d5 
Co-authored-by: Stanislas <skita@teclib.com>
@stonebuzz stonebuzz added the bug label Mar 20, 2025
@stonebuzz stonebuzz self-requested a review March 20, 2025 09:05
@Rom1-B Rom1-B merged commit 5af8b09 into pluginsGLPI:main Mar 20, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stonebuzz stonebuzz stonebuzz approved these changes

@Rom1-B Rom1-B Rom1-B approved these changes

Assignees

@MyvTsv MyvTsv

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MyvTsv @stonebuzz @Rom1-B