Skip to content

Conversation

@stonebuzz
Copy link
Contributor

@stonebuzz stonebuzz commented Mar 18, 2025

Checklist before requesting a review

Please delete options that are not relevant.

  • I have performed a self-review of my code.
  • I have added tests (when available) that prove my fix is effective or that my feature works.
  • I have updated the CHANGELOG with a short functional description of the fix or new feature.
  • This change requires a documentation update.

Description

  • It fixes N/A
    Hide fields 'tab' from template as it's content is not display

Like

    public static function displayTabContentForItem(CommonGLPI $item, $tabnum = 1, $withtemplate = 0)
    {
        if ($withtemplate) {
            //Do not display tab from template or from item created from template
            return false;
        }

but for

public function getTabNameForItem(CommonGLPI $item, $withtemplate = 0)

Screenshots (if appropriate):

@stonebuzz stonebuzz requested a review from Rom1-B March 18, 2025 11:07
@stonebuzz stonebuzz self-assigned this Mar 18, 2025
@stonebuzz stonebuzz force-pushed the do_not_expose_tab_from_fields_on_template branch from 986bebd to a66d4f3 Compare March 19, 2025 10:45
@stonebuzz stonebuzz merged commit 204c9b0 into pluginsGLPI:main Mar 19, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants