Skip to content

Fix: front/ check #949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 5, 2025
Merged

Fix: front/ check #949

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
02c6db4
Fix: front/ check
Rom1-B May 2, 2025
cf30f3e
add check
stonebuzz May 5, 2025
7041665
return
Rom1-B May 5, 2025
fd3cf8d
lint
Rom1-B May 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ajax/container.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,18 @@
*/

include('../../../inc/includes.php');
Session::checkLoginUser();

use Glpi\Http\Response;

if (isset($_GET['action']) && $_GET['action'] === 'get_fields_html') {

$right = PluginFieldsProfile::getRightOnContainer($_SESSION['glpiactiveprofile']['id'], $_GET['id']);
if ($right < READ) {
Response::sendError(403, 'Forbidden');
return;
}

$containers_id = $_GET['id'];
$itemtype = $_GET['itemtype'];
$items_id = (int) $_GET['items_id'];
Expand Down
1 change: 1 addition & 0 deletions ajax/container_display_condition.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
*/

include('../../../inc/includes.php');
Session::checkLoginUser();

if (isset($_GET['action'])) {
if ($_GET['action'] === 'get_add_form') {
Expand Down
1 change: 1 addition & 0 deletions ajax/container_itemtypes_dropdown.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,5 +29,6 @@
*/

include('../../../inc/includes.php');
Session::checkLoginUser();

PluginFieldsContainer::showFormItemtype($_REQUEST);
1 change: 1 addition & 0 deletions ajax/container_subtype_dropdown.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,5 +29,6 @@
*/

include('../../../inc/includes.php');
Session::checkLoginUser();

PluginFieldsContainer::showFormSubtype($_REQUEST, true);
1 change: 1 addition & 0 deletions ajax/reorder.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
*/

include('../../../inc/includes.php');
Session::checkLoginUser();

if (
!array_key_exists('container_id', $_POST)
Expand Down
1 change: 1 addition & 0 deletions ajax/status_override.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
*/

include('../../../inc/includes.php');
Session::checkLoginUser();

if (isset($_GET['action'])) {
if ($_GET['action'] === 'get_status_dropdown') {
Expand Down
1 change: 1 addition & 0 deletions front/commondropdown.form.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
*/

include '../../../inc/includes.php';
Session::checkLoginUser();
if (preg_match('/[a-z]/i', $_REQUEST['ddtype']) !== 1) {
throw new \RuntimeException(sprintf('Invalid itemtype "%1$s"', $_REQUEST['ddtype']));
}
Expand Down
1 change: 1 addition & 0 deletions front/commondropdown.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
*/

include '../../../inc/includes.php';
Session::checkLoginUser();
if (preg_match('/[a-z]/i', $_REQUEST['ddtype']) !== 1) {
throw new \RuntimeException(sprintf('Invalid itemtype "%1$s"', $_REQUEST['ddtype']));
}
Expand Down
7 changes: 7 additions & 0 deletions front/container.form.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
*/

include('../../../inc/includes.php');
Session::checkLoginUser();

if (empty($_GET['id'])) {
$_GET['id'] = '';
Expand Down Expand Up @@ -59,6 +60,12 @@
}
Html::back();
} else {

$right = PluginFieldsProfile::getRightOnContainer($_SESSION['glpiactiveprofile']['id'], $_GET['id']);
if ($right < READ) {
Html::displayRightError("User is missing the " . READ . " ('read') right for container");
}

Html::header(
__('Additional fields', 'fields'),
$_SERVER['PHP_SELF'],
Expand Down
3 changes: 2 additions & 1 deletion front/container.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
*/

include('../../../inc/includes.php');
Session::checkLoginUser();

Html::header(
__('Additional fields', 'fields'),
Expand All @@ -38,7 +39,7 @@
'fieldscontainer',
);

Session::checkRight('entity', READ);
Session::checkRight('config', READ);

PluginFieldsContainer::titleList();
Search::show('PluginFieldsContainer');
Expand Down
1 change: 1 addition & 0 deletions front/containerdisplaycondition.form.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
*/

include('../../../inc/includes.php');
Session::checkRight('config', READ);

$status_override = new PluginFieldsContainerDisplayCondition();
if (isset($_POST['add'])) {
Expand Down
2 changes: 1 addition & 1 deletion front/export_to_yaml.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
include('../../../inc/includes.php');
include('../hook.php');

Session::checkRight('entity', READ);
Session::checkRight('config', READ);

$ID = null;
if (isset($_GET['id'])) {
Expand Down
2 changes: 1 addition & 1 deletion front/field.form.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
$_GET['id'] = '';
}

Session::checkRight('entity', READ);
Session::checkRight('config', READ);

$field = new PluginFieldsField();

Expand Down
1 change: 1 addition & 0 deletions front/labeltranslation.form.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
*/

include('../../../inc/includes.php');
Session::checkRight('config', UPDATE);

$translation = new PluginFieldsLabelTranslation();
if (isset($_POST['add'])) {
Expand Down
1 change: 1 addition & 0 deletions front/profile.form.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
*/

include('../../../inc/includes.php');
Session::checkRight('config', UPDATE);

if (isset($_POST['update'])) {
PluginFieldsProfile::updateProfile($_POST);
Expand Down
2 changes: 1 addition & 1 deletion front/regenerate_files.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
include('../../../inc/includes.php');
include('../hook.php');

Session::checkRight('entity', READ);
Session::checkRight('config', READ);

plugin_fields_checkFiles();

Expand Down
1 change: 1 addition & 0 deletions front/statusoverride.form.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
*/

include('../../../inc/includes.php');
Session::checkRight('config', READ);

$status_override = new PluginFieldsStatusOverride();
if (isset($_POST['add'])) {
Expand Down