Skip to content

Conversation

@bouwew
Copy link
Contributor

@bouwew bouwew commented Oct 17, 2025

Summary by CodeRabbit

  • Bug Fixes

    • Improved detection of removed devices.
  • Chores

    • Updated dependencies.

@sonarqubecloud
Copy link

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 17, 2025

Walkthrough

This is a patch release (v0.58.1) that bumps the upstream Plugwise library dependency from v1.8.0 to v1.8.1 to improve device removal detection. Version and dependency constraints are updated across three configuration files, with a corresponding changelog entry added.

Changes

Cohort / File(s) Change Summary
Version and Dependency Bump
CHANGELOG.md, custom_components/plugwise/manifest.json, pyproject.toml
Updated integration version from 0.58.0 to 0.58.1 and bumped plugwise dependency from 1.8.0 to 1.8.1 for improved device removal detection; added corresponding changelog entry

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

downstreaming

Suggested reviewers

  • CoMPaTech
  • github-actions

Poem

🐰 A nibble here, a version there,
Dependencies bump through the air!
One-eight-one brings detection keen,
Gone devices now are plainly seen!
Patch released with joy and care! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The pull request title "Improve detection of removed device(s) via plugwise v1.8.1" accurately reflects the main objective of the changeset. The PR is a version bump that updates the plugwise dependency from 1.8.0 to 1.8.1 and increments the component version to 0.58.1, with the primary purpose being to incorporate the improved device removal detection provided by plugwise v1.8.1. The title is concise, specific, and clearly communicates the main change without ambiguity or vague terminology.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch pw-1.8.1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
pyproject.toml (1)

28-28: Align version constraint with manifest.json.

The dependencies list declares "plugwise" without a version constraint, while custom_components/plugwise/manifest.json pins it to plugwise==1.8.1. For consistency and to prevent version mismatches in development environments, consider updating this line to also pin to 1.8.1.

-dependencies = ["homeassistant", "plugwise"]
+dependencies = ["homeassistant", "plugwise==1.8.1"]
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dacf712 and 160dc21.

📒 Files selected for processing (3)
  • CHANGELOG.md (1 hunks)
  • custom_components/plugwise/manifest.json (1 hunks)
  • pyproject.toml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Prepare and validate pre-commit
🔇 Additional comments (3)
pyproject.toml (1)

3-3: Version bump is correct and consistent.

The patch version change from 0.58.0 to 0.58.1 aligns with the manifest.json update.

CHANGELOG.md (1)

5-7: Changelog entry is well-formatted and accurately describes the update.

The v0.58.1 entry follows the established pattern, is positioned correctly, and includes a proper link to the upstream release notes.

custom_components/plugwise/manifest.json (1)

10-11: Dependency and version updates are correct.

Both the plugwise library version (1.8.0 → 1.8.1) and component version (0.58.0 → 0.58.1) bumps are appropriate and consistent across the codebase. The pinned dependency version ensures Home Assistant installations use the correct upstream library with the improved device removal detection.

@bouwew bouwew marked this pull request as ready for review October 17, 2025 11:38
@bouwew bouwew requested a review from a team as a code owner October 17, 2025 11:38
@bouwew bouwew merged commit 7739464 into main Oct 17, 2025
13 checks passed
@bouwew bouwew deleted the pw-1.8.1 branch October 17, 2025 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant