-
Notifications
You must be signed in to change notification settings - Fork 7
Improve detection of removed device(s) via plugwise v1.8.1 #943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
WalkthroughThis is a patch release (v0.58.1) that bumps the upstream Plugwise library dependency from v1.8.0 to v1.8.1 to improve device removal detection. Version and dependency constraints are updated across three configuration files, with a corresponding changelog entry added. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
pyproject.toml (1)
28-28: Align version constraint with manifest.json.The
dependencieslist declares"plugwise"without a version constraint, whilecustom_components/plugwise/manifest.jsonpins it toplugwise==1.8.1. For consistency and to prevent version mismatches in development environments, consider updating this line to also pin to1.8.1.-dependencies = ["homeassistant", "plugwise"] +dependencies = ["homeassistant", "plugwise==1.8.1"]
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
CHANGELOG.md(1 hunks)custom_components/plugwise/manifest.json(1 hunks)pyproject.toml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Prepare and validate pre-commit
🔇 Additional comments (3)
pyproject.toml (1)
3-3: Version bump is correct and consistent.The patch version change from 0.58.0 to 0.58.1 aligns with the manifest.json update.
CHANGELOG.md (1)
5-7: Changelog entry is well-formatted and accurately describes the update.The v0.58.1 entry follows the established pattern, is positioned correctly, and includes a proper link to the upstream release notes.
custom_components/plugwise/manifest.json (1)
10-11: Dependency and version updates are correct.Both the plugwise library version (1.8.0 → 1.8.1) and component version (0.58.0 → 0.58.1) bumps are appropriate and consistent across the codebase. The pinned dependency version ensures Home Assistant installations use the correct upstream library with the improved device removal detection.



Summary by CodeRabbit
Bug Fixes
Chores