-
Notifications
You must be signed in to change notification settings - Fork 2
Attempt to fix v5 download issue #315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughUpdated the CI verify workflow to use actions/download-artifact@v5 with filtering and merged downloads into a dedicated artifacts directory, and adjusted the coverage combination step to read from the new location. No other logic changes. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~7 minutes Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #315 +/- ##
=======================================
Coverage 80.70% 80.70%
=======================================
Files 36 36
Lines 7536 7536
=======================================
Hits 6082 6082
Misses 1454 1454 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/verify.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Run pytest using Python 3.13
🔇 Additional comments (1)
.github/workflows/verify.yml (1)
256-260: No collision risk with single Python version — consider future-proofingThe
actions/download-artifactstep still usesmerge-multiple: true, but since the matrix only contains one entry (python-version: ["3.13"]), there’s no risk of.coveragefilename collisions today. To guard against future matrix expansions, you can:
- Remove
merge-multipleto keep each artifact in its own subdirectory and then runcoverage combine artifacts/**/.coverage.- Or rename
.coveragebefore uploading (e.g.mv .coverage .coverage.${{ matrix.python-version }}), keepmerge-multiple: true, and combine withcoverage combine artifacts/.coverage*.This ensures safe aggregation of coverage data whether you have one or many Python versions.
bouwew
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice fix, thanks @CoMPaTech



Summary by CodeRabbit