-
Notifications
You must be signed in to change notification settings - Fork 2
Add missing s in %s #347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing s in %s #347
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #347 +/- ##
==========================================
- Coverage 81.76% 81.67% -0.09%
==========================================
Files 36 36
Lines 8142 8142
==========================================
- Hits 6657 6650 -7
- Misses 1485 1492 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
WalkthroughA logging format string in plugwise_usb/nodes/node.py was corrected within the clear_cache method, changing "Removing node % cache" to "Removing node %s cache" and supplying self._mac_in_str as the argument. No functional behavior or public API signatures were changed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
plugwise_usb/nodes/node.py (1)
394-394: Good fix: correct logging placeholder with deferred formatting.Using
%swith a separate argument avoids eager string interpolation and matches logging best practices.As a small consistency nit, prefer the public
self.macproperty over the private attribute:- _LOGGER.debug("Removing node %s cache", self._mac_in_str) + _LOGGER.debug("Removing node %s cache", self.mac)



Summary by CodeRabbit