Skip to content

Fix auto-joining not functioning as intended #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 24, 2025
Merged

Fix auto-joining not functioning as intended #348

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7048c58
Remove double functionality, already present in node_rejoin_message()
bouwew Sep 24, 2025
13defa7
Update CHANGELOG
bouwew Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,8 @@
- PR [337](https://github.com/plugwise/python-plugwise-usb/pull/337): Improve node removal, remove and reset the node as executed by Source, and remove the cache-file.
- PR [342](https://github.com/plugwise/python-plugwise-usb/pull/342): Improve node_type chaching.
- PR [343](https://github.com/plugwise/python-plugwise-usb/pull/343): Improve writing of cache-files.
- PR [344](https://github.com/plugwise/python-plugwise-usb/pull/344): Don't store plus-device in nodetypes cache
- PR [344](https://github.com/plugwise/python-plugwise-usb/pull/344): Don't store plus-device in nodetypes cache.
- PR [348](https://github.com/plugwise/python-plugwise-usb/pull/348): Fix broken auto-joining.

## 0.46.0 - 2025-09-12

Expand Down
2 changes: 0 additions & 2 deletions plugwise_usb/network/registry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,8 +263,6 @@ async def register_node(self, mac: str) -> None:
await request.send()
except StickError as exc:
raise NodeError(f"{exc}") from exc
if self.update_network_registration(mac):
await self._exec_node_discover_callback(mac, None, False)

async def unregister_node(self, node: PlugwiseNode) -> None:
"""Unregister node from current Plugwise network."""
Expand Down