Skip to content

Conversation

@CoMPaTech
Copy link
Member

@CoMPaTech CoMPaTech commented Jan 9, 2023

Blocked until HA-core/package_constraints.txt is bumped to aiohttp>3.8.1

@CoMPaTech CoMPaTech added enhancement New feature or request dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Jan 9, 2023
@CoMPaTech CoMPaTech self-assigned this Jan 9, 2023
@frenck
Copy link
Contributor

frenck commented Jan 9, 2023

Blocked until HA-core/package_constraints.txt is bumped to aiohttp-3.8.3

That won't happen aiohttp 3.8.3 has a serious memory leak, we have reverted that upgrade and are awaiting upstream. One thing is for sure, it will never ben 3.8.3 again :)

@CoMPaTech
Copy link
Member Author

Noted, thanks for the explanation - waiting for upstream bump of aiohttp above 3.8.1 - adjusted the initial comment to say > 3.8.1 :)

@codecov
Copy link

codecov bot commented Feb 25, 2023

Codecov Report

Merging #259 (28e2aaa) into main (50f92cd) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #259   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines         2663      2663           
=========================================
  Hits          2663      2663           
Impacted Files Coverage Δ
plugwise/helper.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@CoMPaTech
Copy link
Member Author

@brefra (or @bouwew) could you look at plugwise/connections/socket.py I think pylint is rightfully stating the no-raise-else and it suggest to just de-indent (which I now did)

@bouwew why did we have HomeAssistantError in pyproject (otherwise we'll need to re-add it prepended by the module, just like with the built-ins)

@CoMPaTech
Copy link
Member Author

For record keeping, following up with aiohttp 3.8.4 as now in core (though core is also still waiting for 3.9 release)

@bouwew
Copy link
Contributor

bouwew commented Feb 25, 2023

@CoMPaTech, HomeAssistantError, must be a left-over or a mistake.
Not used anywhere.

@CoMPaTech CoMPaTech marked this pull request as ready for review February 25, 2023 14:43
@CoMPaTech CoMPaTech requested a review from bouwew February 25, 2023 14:43
Copy link
Contributor

@bouwew bouwew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CoMPaTech
Copy link
Member Author

As discussed on the side, not defaulting to 3.11 yet

@CoMPaTech CoMPaTech merged commit 5372257 into main Feb 25, 2023
@CoMPaTech CoMPaTech deleted the python311 branch February 25, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file enhancement New feature or request python Pull requests that update Python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants