Fix m_adam_heating #309
Merged
Fix m_adam_heating #309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #309 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 2629 2629
=========================================
Hits 2629 2629 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bouwew
requested changes
May 4, 2023
Contributor
bouwew
left a comment
bouwew
left a comment
There was a problem hiding this comment.
The change is correct.
But, the name domestic_hot_water_setpoint has changed for all fixtures to max_dhw_temperature as a part of the v0.31.3 updates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix m_adam_heating (through reviewing core pr)