Skip to content

Improve test-code #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 16, 2024
Merged

Improve test-code #534

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9982ddc
Correct typo
bouwew Mar 16, 2024
6d85d08
Remove guard
bouwew Mar 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions tests/test_init.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -944,13 +944,12 @@ def validate_test_basics(
log_msg = f" # Assert version matching '{smile_version}"
parent_logger.info(log_msg)
assert smile.smile_version == smile_version
if smile_version:
log_msg = f" # Assert legacy {smile_legacy}"
parent_logger.info(log_msg)
if smile_legacy:
assert smile.smile_legacy
else:
assert not smile.smile_legacy
log_msg = f" # Assert legacy {smile_legacy}"
parent_logger.info(log_msg)
if smile_legacy:
assert smile.smile_legacy
else:
assert not smile.smile_legacy

class PlugwiseTestError(Exception):
"""Plugwise test exceptions class."""
Expand Down