Skip to content

Replace slave and master with secondary and main #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 17, 2024
Merged

Replace slave and master with secondary and main #536

merged 7 commits into from
Mar 17, 2024

Conversation

bouwew
Copy link
Contributor

@bouwew bouwew commented Mar 17, 2024

No description provided.

@bouwew bouwew requested a review from a team as a code owner March 17, 2024 13:29
@bouwew bouwew requested a review from CoMPaTech March 17, 2024 13:29
CoMPaTech
CoMPaTech approved these changes Mar 17, 2024
View reviewed changes
Copy link
Member

@CoMPaTech CoMPaTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To prevent confusion (main/mains) I'd opt for primary or something else for main.

@codecov Codecov
Copy link

codecov bot commented Mar 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (1e4826c) to head (86ec5b7).

Additional details and impacted files 
@@            Coverage Diff            @@
##              main      #536   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines         3161      3161           
=========================================
  Hits          3161      3161

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@bouwew bouwew merged commit aadeb4f into main Mar 17, 2024
@bouwew bouwew deleted the remove_slave branch March 17, 2024 19:27
@bouwew bouwew mentioned this pull request Mar 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CoMPaTech CoMPaTech CoMPaTech approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bouwew @CoMPaTech