Skip to content

Conversation

bouwew
Copy link
Contributor

@bouwew bouwew commented May 16, 2024

I realized that the thermostat-select for the legacy Anna only has one schedule-option.
The Off-option was added so the select of the Plugwise HA integration works the same as for the non-legacy thermostats.
Also, detection of an empty schedule was added.

Finally, a small correction was made for actual devices.

Furthermore, all in [..., ...] constructs were replaced by in (..., ...) constructs including one typing-item in constants.py: Final[list[str]] to Final[tuple[str, ...]].
And, some double used code was replaced by a common function, common_match_cases().

@bouwew bouwew requested a review from CoMPaTech May 16, 2024 17:54
Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f72847c) to head (b31d57b).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #558   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        20           
  Lines         3150      3138   -12     
=========================================
- Hits          3150      3138   -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bouwew bouwew changed the title Fix schedule-select for legacy Anna Schedule-improvements May 17, 2024
@bouwew bouwew marked this pull request as ready for review May 17, 2024 17:51
@bouwew bouwew requested a review from a team as a code owner May 17, 2024 17:51
@bouwew bouwew changed the title Schedule-improvements Schedule-related improvements May 17, 2024
@bouwew bouwew force-pushed the fix-legacy-schedule branch 2 times, most recently from 3793e41 to e498821 Compare May 18, 2024 10:18
@bouwew bouwew force-pushed the fix-legacy-schedule branch from e498821 to 43483d8 Compare May 18, 2024 10:28
@bouwew bouwew requested a review from CoMPaTech May 18, 2024 10:36
@bouwew bouwew force-pushed the fix-legacy-schedule branch from af8f332 to b31d57b Compare May 18, 2024 16:30
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
2.3% Duplication on New Code

See analysis details on SonarCloud

@bouwew bouwew merged commit 02802b3 into main May 19, 2024
@bouwew bouwew deleted the fix-legacy-schedule branch May 19, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants