Don't output schedule-related data when no valid schedule(s) found #559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adapting to plugwise v0.37.6
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #559 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 20
Lines 3138 3140 +2
=========================================
+ Hits 3138 3140 +2 ☔ View full report in Codecov by Sentry. |
bouwew
changed the title
CoMPaTech
approved these changes
May 19, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to implement v0.37.6 into plugwise-beta (Select-platform) I ran into a problem.
I realized this was best fixed in the backend by not outputting the schedule(s) data when there is(are) no valid schedule(s) present. So this was implemented.
During this process I corrected the manual-fixture script, and some omissions in the legacy_anna data.
Please see plugwise/plugwise-beta#644 for the corresponding changes in pw-beta.