-
Notifications
You must be signed in to change notification settings - Fork 8
Fix coverage from recent v3/v4 changes #615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe pull request modifies the GitHub Actions workflow file Changes
Possibly related PRs
Suggested labels
Poem
Tip New featuresWalkthrough comment now includes:
Notes:
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #615 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 20
Lines 3345 3345
=========================================
Hits 3345 3345 ☔ View full report in Codecov by Sentry. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/verify.yml (3 hunks)
Additional context used
actionlint
.github/workflows/verify.yml
245-245: input "include-hidden-files" is not defined in action "actions/upload-artifact@v4". available inputs are "compression-level", "if-no-files-found", "name", "overwrite", "path", "retention-days"
(action)
if-no-files-found: error | ||
include-hidden-files: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the invalid include-hidden-files
parameter.
The addition of the if-no-files-found: error
parameter looks good as it specifies error handling when no files are found.
However, the include-hidden-files: true
parameter is not a valid input for the actions/upload-artifact@v4
action. Please remove it.
Apply this diff to remove the invalid parameter:
- include-hidden-files: true
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
if-no-files-found: error | |
include-hidden-files: true | |
if-no-files-found: error |
Tools
actionlint
245-245: input "include-hidden-files" is not defined in action "actions/upload-artifact@v4". available inputs are "compression-level", "if-no-files-found", "name", "overwrite", "path", "retention-days"
(action)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Apart dat Coderabbitai achterloopt...
Fixes aligning from actions/upload-artifact#602
Summary by CodeRabbit
aiohttp
library.