Skip to content

Conversation

UncleOwen
Copy link
Member

@UncleOwen UncleOwen commented Sep 8, 2025

Since I ran into this twice in short succession, I figured I might just as well fix this.

Applies a simple heuristic: If the name of a rule starts with 'Abstract', it's an abstract class. This could change any number of rules, so let's bail and just compare all rules.

My knowledge of ruby is very basic. I basically copied one of the other "compare all rules" test cases.

Fixes #124

@UncleOwen UncleOwen changed the title Issue 140: If an abstract rule is changed, run all rules Fix #140: If an abstract rule is changed, run all rules Sep 8, 2025
@adangel adangel changed the title Fix #140: If an abstract rule is changed, run all rules Fix #124: If an abstract rule is changed, run all rules Sep 19, 2025
@adangel adangel added this to the next milestone Sep 19, 2025
@adangel
Copy link
Member

adangel commented Sep 19, 2025

merged via a7a756a

@zbynek
Copy link

zbynek commented Sep 21, 2025

@UncleOwen this does not cover classes that are in the internal package, but are not called Abstract*. On the other hand it treats some actual rules as abstract classes, such as AbstractClassWithoutAbstractMethodRule. I wonder if it would make sense to move all non-instantiable classes to the internal package and check only for internal.

@UncleOwen UncleOwen deleted the issue-140-bail-on-abstract-rules branch September 21, 2025 12:50
@UncleOwen
Copy link
Member Author

@zbynek I know. See the resolved discussion with adangel above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

With --auto-gen-config invalid rule references might be generated

3 participants