Incorrect inferred return type (?)

[MariaSolOs]

Notice how inlay hints correctly show how the inferred return type is string, which contradicts the diagnostic.

This doesn't happen in VS Code.

If you want to investigate @pmizio, the repro is opening this file.

[pmizio]

I see that and I will look into it deeper for now I was able to determinate potential elephant in the room - semanticTokens, as workaround if you don't care too much about semanticTokens you can disable them and sync problem disappear. Call this:
client.server_capabilities.semanticTokensProvider = nil in your on_attach function.

Or maybe you have some insider info which can be helpful in fixing this? For now I will try to "reverse engineer" this from vscode code and tsserver logs, but it may take some time sorry :(

Edit. ok I think I found solution https://github.com/microsoft/vscode/blob/2bd04a1380e93fa92294878b17305f246f7f334a/extensions/typescript-language-features/src/languageFeatures/semanticTokens.ts#L14 vscode stop asking about semantic tokens when file is larger then value of this const and file mentioned by you is. So probably this performance reasons mentioned in comment above constant kicks in.

I try to test it soon.

[KostkaBrukowa]

Just out of curiosity, why semantic tokens impact diagnostics?

[MariaSolOs]

@pmizio Thank you for the amazing investigation! I thought it was caused by the separate diagnostic server being out of sync with the syntax one (since I found it really weird how the same client would infer different types for different LSP methods), but you're the pro here :)

[pmizio]

@KostkaBrukowa Honestly no idea, I checked requests one by one and this one fixed problem. But both have sementic component and runned on same server so maybe this is a link.

Edit: I suppose this is indeed connected with file size because it have ~7k lines and over 200000 of chars it can be expensive.

[MariaSolOs]

@pmizio amazing. Also sorry for stress-testing your plugin with literally one of the most complicated repos out there 😸

[pmizio]

It's ok, if I didn't want this, the repo would still be private 😉

[pmizio]

@MariaSolOs pr #79 contain change - now for this large files semantic tokens are skipped. Can you verify this on free time?

[MariaSolOs]

@pmizio I just tried your branch in the TypeScript repo, and it works :)

[MariaSolOs]

While testing though, I noticed that inlay hints are only displayed after entering insert mode. Not sure if this is intended.

[pmizio]

@MariaSolOs True, I only tested them only by enabling them manually using cmdline. So I just cannot notice this. But it should be fixed now in mentioned pr.

[pmizio]

@MariaSolOs I just merged it into master let me know if inlay hints an previous issue are fixed and this issue can by possibly closed