feat: add pkg.pr.new

[AmirSa12]

Summary

This PR adds pkg.pr.new

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
valtio	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 20, 2024 6:20am

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

[AmirSa12]

OK we still have the same issue, even after opening a new PR. ( the check fails at first then it goes green automatically after few seconds)

[AmirSa12]

OK now we know the reason. according to PR #896 , the reason the check failed at first was that the workflows were running in my fork and I didn't install the app myself, so it failed on my fork and the result were being shared with you all !! @dai-shi I apologize for the confusions caused by my emails :)

[pkg-pr-new]

Last Commit Build: 349cf69

valtio(349cf69):

npm i https://pkg.pr.new/valtio@349cf69    

Pull Request Build: #898

valtio(#898):

npm i https://pkg.pr.new/valtio@898    

[dai-shi]

I don't receive the email, which is good. Thanks.

Now, I get this error:

$ npm i https://pkg.pr.new/pmndrs/valtio@99014aa    
npm ERR! code E404
npm ERR! 404 Cannot find any route matching /pmndrs/valtio@99014aa. - GET https://pkg.pr.new/pmndrs/valtio@99014aa
npm ERR! 404 
npm ERR! 404  'https://pkg.pr.new/pmndrs/valtio@99014aa' is not in this registry.
npm ERR! 404 This package name is not valid, because 
npm ERR! 404  1. name can only contain URL-friendly characters
npm ERR! 404 
npm ERR! 404 Note that you can also install from a
npm ERR! 404 tarball, folder, http url, or git url.

npm ERR! A complete log of this run can be found in: /Users/daishi/.npm/_logs/2024-05-19T22_26_04_669Z-debug-0.log

[dai-shi]

@Aslemammad I don't know the technical detail, but it would be super nice if it didn't require the app. Why github action isn't enough if you have a backend server?

[Aslemammad]

Now, I get this error:

I'll try fixing this asap! Sorry for the error.

but it would be super nice if it didn't require the app

Yep, but we need to listen to PR & commit events so we validate if a certain workflow is a verified workflow. This also helps in avoiding spam publishes or local publishes. The app is also required for commenting.
Let me know if I'm wrong, it'd be really good to avoid friction by removing the app.

[Aslemammad]

The issue is upstream, sorry for that! Feel free to convert the PR to draft until my fix get merged.

[Aslemammad]

But we can try compact mode too! Let's try that meanwhile.

[dai-shi]

What's compact mode?

[Aslemammad]

--compact makes the urls way shorter if the package exists on npm!

like:
npm i https://pkg.pr.new/valtio@349cf69, no repo & org name!

[Aslemammad]

It works now, let me know what you think Daishi!

[dai-shi]

Not sure how to deal with name collisions, but I don't mind.
Let's merge it and see how it goes in this repo. It would be nice if it creates some sandboxes too.