Fix warnings about unused varyings#38
Merged
hccampos merged 1 commit intopnext:masterfrom Apr 1, 2019
Merged
Conversation
…uld be optimized out. Observed on Chrome on MacOS with AMD Radeon R9 M370X.
Contributor
|
Thank you @rhuitl ! This will be a pain to maintain, but it is indeed pretty annoying to get all those warnings. |
Contributor
Author
|
Yes I know! It's really annoying but I don't know a better solution at the moment. Maybe reducing the preprocessor complexity in the first place, e.g. have more different sets of shaders and use Webpack to @import common code parts. |
Contributor
|
Also released in v0.0.19 @rhuitl |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
by not declaring them when they would be optimized out.
Observed on Chrome on MacOS with AMD Radeon R9 M370X.